Smarty - Nested Function calls when using Objects

Wed, 12/07/2006 - 08:16 — David Goodwin

Smarty - Nested/Chained function calls when using Objects

When using Smarty, I've been trying to embed something like the following to chain method calls together :


{$theObject->getUser()->getName()}

That, at least with Smarty 2.4.14, doesn't work.

Thankfully, #smarty on freenode, provided the following fix which I'll include here, just incase the link breaks :


Index: Smarty_Compiler.class.php
===================================================================
RCS file: /repository/smarty/libs/Smarty_Compiler.class.php,v
retrieving revision 1.382
diff -u -r1.382 Smarty_Compiler.class.php
--- Smarty_Compiler.class.php	28 May 2006 17:35:05 -0000	1.382
+++ Smarty_Compiler.class.php	11 Jul 2006 14:57:13 -0000
@@ -161,7 +161,7 @@
         $this->_obj_params_regexp = '\((?:' . $this->_obj_single_param_regexp
                 . '(?:\s*,\s*' . $this->_obj_single_param_regexp . ')*)?\)';
         $this->_obj_start_regexp = '(?:' . $this->_dvar_regexp . '(?:' . $this->_obj_ext_regexp . ')+)';
-        $this->_obj_call_regexp = '(?:' . $this->_obj_start_regexp . '(?:' . $this->_obj_params_regexp . ')?(?:' . $this->_dvar_math_regexp . '(?:' . $this->_num_const_regexp . '|' . $this->_dvar_math_var_regexp . ')*)?)';
+        $this->_obj_call_regexp = '(?:' . $this->_obj_start_regexp . '(?:' . $this->_obj_params_regexp . '' . '(?:' . $this->_obj_ext_regexp . $this->_obj_params_regexp . ')*' . ')?(?:' . $this->_dvar_math_regexp . '(?:' . $this->_num_const_regexp . '|' . $this->_dvar_math_var_regexp . ')*)?)';
         
         // matches valid modifier syntax:
         // |foo

So that now works properly, and I don't have to do something nasty like :


{php} echo $this->_tpl_vars['theObject']->getUser()->getName(); {/php}

Technorati Tags:

Smarty

David Goodwin's blog

Comments

Tue, 10/04/2007 - 15:30 — Greg (not verified)

Small world, having the same

Small world, having the same problem and found your patch. All was good until we updated a (test!) server to Etch today, and now we get:
Warning: preg_match() [function.preg-match]: Compilation failed: repeated subpattern is too long at offset 18444 in /mnt/websites/godiva.te/lib/smarty/Smarty_Compiler.class.php on line 438

any suggestions? :)

Greg

Tue, 10/04/2007 - 18:35 — David Goodwin

yes... been there, fixed that ...

You'll need to compile pcre yourself; see this post and it will work perfectly.

(Sorry for not including more details on the error message in the post, but such is life)

David.

Fri, 27/04/2007 - 19:32 — David Goodwin

pcre fixed in php 5.2.2rc2

it seems (from a quick test) that it's not necessary to compile php against an external installation of pcre with php 5.2.2RC2.

Mon, 07/01/2008 - 14:30 — Martin (not verified)

But property calls doesn't work

{$object->getUser()->username}

Smarty error: [in html:home.tpl line 48]: syntax error: unrecognized tag: $object->getUser()->username

{$object->getUser()->getUsername()} works

Greetings from Germany,
Martin

Mon, 07/01/2008 - 16:36 — David Goodwin

odd

I've not come across that before; to be honest the Smarty patch is like black magic to me, and I hope I never have to try and fix/modify/alter it

Fri, 05/09/2008 - 09:19 — Willem Stuursma (not verified)

Property calls

Property calls work with this patch:
### Eclipse Workspace Patch 1.0 #P smarty Index: Smarty_Compiler.class.php =================================================================== --- Smarty_Compiler.class.php (revision 34623) +++ Smarty_Compiler.class.php (working copy) @@ -152,6 +152,8 @@ // $foo->bar($foo->bar) // $foo->bar($foo->bar()) // $foo->bar($foo->bar($blah,$foo,44,"foo",$foo[0].bar)) + // $foo->getBar()->getFoo() + // $foo->getBar()->foo $this->_obj_ext_regexp = '\->(?:\$?' . $this->_dvar_guts_regexp . ')'; $this->_obj_restricted_param_regexp = '(?:' . '(?:' . $this->_var_regexp . '|' . $this->_num_const_regexp . ')(?:' . $this->_obj_ext_regexp . '(?:$(?:(?:' . $this->_var_regexp . '|' . $this->_num_const_regexp . ')' @@ -161,7 +163,7 @@ $this->_obj_params_regexp = '\((?:' . $this->_obj_single_param_regexp . '(?:\s*,\s*' . $this->_obj_single_param_regexp . ')*)?$'; $this->_obj_start_regexp = '(?:' . $this->_dvar_regexp . '(?:' . $this->_obj_ext_regexp . ')+)'; - $this->_obj_call_regexp = '(?:' . $this->_obj_start_regexp . '(?:' . $this->_obj_params_regexp . '(?:' . $this->_obj_ext_regexp . $this->_obj_params_regexp . ')*' . ')?(?:' . $this->_dvar_math_regexp . '(?:' . $this->_num_const_regexp . '|' . $this->_dvar_math_var_regexp . ')*)?)'; + $this->_obj_call_regexp = '(?:' . $this->_obj_start_regexp . '(?:' . $this->_obj_params_regexp . '(?:' . $this->_obj_ext_regexp . '(?:'.$this->_obj_params_regexp . ')?)*' . ')?(?:' . $this->_dvar_math_regexp . '(?:' . $this->_num_const_regexp . '|' . $this->_dvar_math_var_regexp . ')*)?)';

// matches valid modifier syntax: // |foo

Fri, 05/09/2008 - 17:45 — David Goodwin

I've no idea how people do 'patch' on Windows, but presumably there is a port of it.

David

David Goodwin

Recent blog posts

Who's online

Recent comments

Syndicate